-
Notifications
You must be signed in to change notification settings - Fork 292
[AMD] Port MI355X DeepSeek V4 fixed-sequence disagg to srt-slurm #2630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
23
commits into
main
Choose a base branch
from
agent/port-dsv4-mi355x-fixedseq-srt-slurm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0a89453
refactor(amd): centralize MI355X srt-slurm runtime
cquil11 0674eaa
fix(amd): stream srt-slurm stdout in Actions
cquil11 6439c63
fix(amd): preserve fixed-seq launch semantics
cquil11 d0b0f31
fix(amd): reclaim stale hugepages before srt workers
cquil11 429de0f
fix(ci): reclaim legacy AMD runner files before checkout
cquil11 190a387
fix(amd): pin lm-eval pip compatibility
cquil11 74c0c85
fix(amd): pin eval framework runtime
cquil11 c94d0a4
fix(amd): preserve legacy AgentX fabric semantics
cquil11 2a10192
fix(amd): pin writable lm-eval cache runtime
cquil11 847c80f
fix(amd): retain srt lm-eval result artifacts
cquil11 539f2fa
fix(amd): use srt lm-eval result contract
cquil11 09f2299
Merge remote-tracking branch 'origin/main' into codex/base-pin-eval
cquil11 82f3781
fix(amd): propagate srt lm-eval artifact sink
cquil11 9092e3d
fix(amd): pass eval result sink through srt
cquil11 3521b76
merge: sync AMD srt integration with main
cquil11 eac80c2
merge: sync AMD srt integration with latest main
cquil11 cdb9e5f
fix(amd): forward workflow random workload ratio to srt benchmarks
cquil11 ac0c6a6
feat(amd): port DSV4 fixed-sequence to srt-slurm
cquil11 50dc6d5
fix(amd): preserve DSV4 fixed-sequence semantics
cquil11 dc8d902
fix(amd): preserve DSV4 MoRI dispatch pin
cquil11 7822374
fix(amd): restore upstream DSV4 fixed-sequence contract
cquil11 7662a18
fix(amd): preserve explicit DSV4 RDMA device selection
cquil11 c38fb02
fix(amd): restore legacy DeepSeek V4 benchmark length distribution
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
177 changes: 0 additions & 177 deletions
177
benchmarks/multi_node/agentic/dsv4_fp4_mi355x_sglang-disagg.sh
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cache flush uses metrics URLs
Medium Severity
clear_agentic_worker_cachesreadsAIPERF_SERVER_METRICS_URLSand returns success when that variable is unset. The retired replay flushed workers viaSERVER_FLUSH_URLS_CSV, which was always populated and distinct from optional metrics scrape URLs. Cache isolation between concurrency points is skipped whenever metrics URLs are absent.Additional Locations (1)
benchmarks/multi_node/agentic_srt.sh#L185-L188Reviewed by Cursor Bugbot for commit 84b6055. Configure here.