Skip to content

[feat][nv] Add Kimi K3 B200 configs - #2618

Closed
xinli-sw wants to merge 1 commit into
mainfrom
kimik3-b200-dcp8-refresh
Closed

[feat][nv] Add Kimi K3 B200 configs #2618
xinli-sw wants to merge 1 commit into
mainfrom
kimik3-b200-dcp8-refresh

Conversation

@xinli-sw

Copy link
Copy Markdown
Collaborator

No description provided.

@xinli-sw
xinli-sw requested a review from a team August 15, 2026 14:50
@xinli-sw
xinli-sw marked this pull request as draft August 15, 2026 14:50
@xinli-sw
xinli-sw marked this pull request as ready for review August 15, 2026 14:51
Comment on lines +96 to +98
# Throughput runs use the committed K7 golden synthetic AL 3.84. Eval
# selects the paired real-verification recipe instead.
speculative-config: '{"model":"Inferact/Kimi-K3-DSpark","num_speculative_tokens":7,"method":"dspark","attention_backend":"FLASHINFER_MLA","draft_sample_method":"probabilistic","rejection_sample_method":"synthetic","synthetic_acceptance_length":3.84}'
speculative-config: '{"model":"Inferact/Kimi-K3-DSpark","num_speculative_tokens":3,"method":"dspark","attention_backend":"TOKENSPEED_MLA","draft_sample_method":"probabilistic","rejection_sample_method":"synthetic","synthetic_acceptance_length":3.0}'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The comment above speculative-config in agg-b200-tp8dp2-vllm-simple-offload-dspark-agentic.yaml (lines 96-97) still says "Throughput runs use the committed K7 golden synthetic AL 3.84", but this PR changed this recipe's speculative-config to num_speculative_tokens:3/synthetic_acceptance_length:3.0 (banded DSpark: level 7 at concurrency<=8, level 3 above). Please update the comment to reflect level 3 / AL 3.0 for this higher-concurrency offload arm.

Extended reasoning...

The comment block directly above the speculative-config line in agg-b200-tp8dp2-vllm-simple-offload-dspark-agentic.yaml (lines 96-97) reads:

# Throughput runs use the committed K7 golden synthetic AL 3.84. Eval
# selects the paired real-verification recipe instead.

That text was accurate before this PR, when the recipe used num_speculative_tokens:7 and synthetic_acceptance_length:3.84 (K7 = DSpark level 7, AL 3.84). This PR changes that same speculative-config line (line 98) to num_speculative_tokens:3 and synthetic_acceptance_length:3.0, but leaves the comment text untouched, so the comment now describes a configuration the file no longer uses.

The change is intentional and correct on the config side: perf-changelog.yaml's new entry for this PR describes banded DSpark — "level 7 at concurrency 8 and below and level 3 above it" — and this offload recipe runs at much higher concurrency (max-num-seqs: 96), so moving it to level 3 / AL 3.0 is the right call. The sibling agg-b200-tp8dp2-latency-dspark-agentic.yaml, which runs at low concurrency (max-num-seqs: 16) and correctly stayed on num_speculative_tokens:7/AL 3.84, kept the identical comment — and there it is still accurate, confirming the comment in the offload file is what fell out of sync.

Nothing prevents this drift structurally: the comment is a free-text annotation next to a JSON blob in YAML, so there is no lint or schema check tying the prose to the num_speculative_tokens/synthetic_acceptance_length values. It is purely on the author to keep them in sync when editing the JSON.

Concrete proof: (1) pre-PR, this file had num_speculative_tokens:7, synthetic_acceptance_length:3.84, matching "K7 golden synthetic AL 3.84". (2) The PR diff for this file changes only the JSON values to num_speculative_tokens:3, synthetic_acceptance_length:3.0, and does not touch the two comment lines above it. (3) Reading the file post-PR, the comment and the config it annotates now disagree — a maintainer skimming the comment would believe this arm still runs K7/AL 3.84 when it actually runs K3/AL 3.0.

The fix is a one-line comment edit: change "Throughput runs use the committed K7 golden synthetic AL 3.84" to something like "Throughput runs use the committed K3 golden synthetic AL 3.0 (banded DSpark for this higher-concurrency offload arm)". This has no effect on runtime behavior since YAML comments are inert, so it is a documentation-only nit rather than a blocking issue.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw
xinli-sw force-pushed the kimik3-b200-dcp8-refresh branch from dd56804 to 8c5a8b5 Compare August 18, 2026 23:44
@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw
xinli-sw force-pushed the kimik3-b200-dcp8-refresh branch from 8c5a8b5 to c150eb1 Compare August 18, 2026 23:48
@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw
xinli-sw force-pushed the kimik3-b200-dcp8-refresh branch from c150eb1 to 4cfd94f Compare August 18, 2026 23:52
@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw xinli-sw changed the title [wip][nv] k3 b200 dcp8 [feat][nv] Add Kimi K3 B200 configs Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw
xinli-sw force-pushed the kimik3-b200-dcp8-refresh branch from 4cfd94f to afae6b6 Compare August 19, 2026 01:56
Two-node TP8 x DP2 x EP16 with DCP8, offloading every point to a Mooncake
external tier. Concurrency 1 to 8 drafts with DSpark level 7, 10 to 16 with
level 3, and 18 to 24 runs unspeculated, with the golden acceptance length
injected only for throughput so eval verifies against the target model.
Runs on the b200-nscale cluster, rendered by upstream srt-slurm.
@xinli-sw
xinli-sw force-pushed the kimik3-b200-dcp8-refresh branch from afae6b6 to ced99b4 Compare August 19, 2026 01:57
@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@xinli-sw

Copy link
Copy Markdown
Collaborator Author

closed in favor of #2672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant