Repository navigation
feat(ci): support additive append-only curve updates #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
46353f8
feat(ci): add append-only curve sweeps
cquil11 bded8e1
fix(ci): allow point-gated launch script changes
cquil11 598c9f5
fix(ci): defer append-only impact checks to review
cquil11 9893aac
feat(ci): support additive append-only recipes
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 AGENTS.md and docs/documentation-procedures.md require every English contributor-facing doc change to be synced into its
_zh.mdcounterpart in the same PR, and explicitly namedocs/PR_REVIEW_CHECKLIST.mdas needing English-verbatim sync in both language files. This PR adds a new append-only checklist bullet todocs/PR_REVIEW_CHECKLIST.md(line 31) and a new 'Adding points to the latest curve withappend-only' section toCONTRIBUTING.md, but touches neitherdocs/PR_REVIEW_CHECKLIST_zh.mdnorCONTRIBUTING_zh.md— both now diverge from their English source.Extended reasoning...
The bug:
docs/documentation-procedures.mdestablishes a repo-mandated, same-PR bilingual sync requirement for contributor-facing docs: line 11 states_Required:_ Write or update the English page first, then translate it into the matching Simplified Chinese_zh.mdpage in the same change_", and line 129 repeats "Translate the finalized English changes into the matching_zh.mdpage in the same PR." The 'Special case: the PR review checklist' section (around line 136) goes further and explicitly names this exact file:docs/PR_REVIEW_CHECKLIST.md's template 'must remain English-verbatim in **both** checklist language files because the verifier detects exact English wording.'AGENTS.mdline 16 reiterates that contributor-facing docs ship with a synchronized_zh.md` page.Where it manifests in this PR: the diff adds a new checklist bullet to
docs/PR_REVIEW_CHECKLIST.md(the append-only sign-off verification item, at line 31) and an entirely new section, 'Adding points to the latest curve withappend-only', toCONTRIBUTING.md. Neitherdocs/PR_REVIEW_CHECKLIST_zh.mdnorCONTRIBUTING_zh.mdappears anywhere in this PR's 8 changed files.Proof: both zh files are genuine bilingual pairs today (each carries the reciprocal
English | 中文switcher, andPR_REVIEW_CHECKLIST_zh.mdeven instructs reviewers to copy the checklist template verbatim in English — see its own note: '模板请保持英文原文,原样复制粘贴,不要翻译'). Grepping both files for 'append-only' after this PR returns zero matches:grep -c append-only CONTRIBUTING_zh.md docs/PR_REVIEW_CHECKLIST_zh.md→0,0.So after merge, an English-only reader sees the new append-only workflow documented in both
CONTRIBUTING.mdand the checklist, while a Chinese-only reader sees neither — the checklist item a CODEOWNER is supposed to check off is simply absent from the zh template they'd copy from, and the zh contributing guide gives no explanation of whatappend-only: truemeans or when to use it.Why nothing else catches this: there is no CI check enforcing bilingual parity; the requirement is purely a documented human-process convention in
documentation-procedures.md, so it's easy for a PR that only touches English docs to slip through review unless a reviewer explicitly diffs the zh counterparts.The fix: append the same checklist bullet (kept English-verbatim, matching the existing convention for that template) to
docs/PR_REVIEW_CHECKLIST_zh.md, and add a translated 'Adding points to the latest curve withappend-only' section toCONTRIBUTING_zh.mdmirroring the new English section (code block and YAML example preserved verbatim, prose translated), perdocumentation-procedures.md's 'Update an existing bilingual pair' procedure.