Repository navigation
[AMD] [AGENTX] Qwen3.5 FP4 MI355X SGLang Agentic MTP / Qwen3.5 FP4 MI355X SGLang Agentic 数据集 MTP 基准配置 - #2605
Closed
ChangLiu0709 wants to merge 9 commits into
Closed
ChangLiu0709 wants to merge 9 commits into
ChangLiu0709 wants to merge 9 commits into
Claude / Claude Code Review
completed
Aug 14, 2026 in 14m 19s
Code review found 2 important issues
Found 4 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | configs/amd-master.yaml:389 |
New agentic script is unreachable dead code: spec-decoding:mtp routes both configs to the stale pre-existing _mtp.sh |
Annotations
Check failure on line 389 in configs/amd-master.yaml
claude / Claude Code Review
New agentic script is unreachable dead code: spec-decoding:mtp routes both configs to the stale pre-existing _mtp.sh
Both new/updated search-space arms in `configs/amd-master.yaml` (`qwen3.5-fp4-mi355x-sglang-agentic` line 389 and `qwen3.5-fp4-mi355x-sglang-agentic-mtp` line 401) set `spec-decoding: mtp`, which makes `runners/launch_mi355x-amds.sh` route both to the pre-existing `qwen3.5_fp4_mi355x_sglang_mtp.sh` (num-steps=3, draft-tokens=4, acc-len=3.39) instead of the new `qwen3.5_fp4_mi355x_sglang.sh` this PR adds (num-steps=5, draft-tokens=6, acc-len=3.61, HiCache). The new script's suffix-less filename i
Loading