Skip to content

perf(agentx): refresh dsv4-fp4-b200-vllm-agentic-mtp harness - #2516

Merged
cquil11 merged 6 commits into
mainfrom
agent/refresh-dsv4-b200-vllm-agentic-mtp
Aug 8, 2026
Merged

perf(agentx): refresh dsv4-fp4-b200-vllm-agentic-mtp harness#2516
cquil11 merged 6 commits into
mainfrom
agent/refresh-dsv4-b200-vllm-agentic-mtp

Conversation

@cquil11

@cquil11 cquil11 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a perf changelog entry for dsv4-fp4-b200-vllm-agentic-mtp.
  • Refresh the submission with the up-to-date AgentX harness.
  • Explicitly pass the vLLM backend Prometheus endpoint to AIPerf for every topology and require vllm: metrics before publishing results. This preserves automatic direct-server collection for pure TP and adds engine metrics alongside router metrics for DP-attention.

Validation

  • bash -n benchmarks/single_node/agentic/dsv4_fp4_b200_vllm_mtp.sh
  • python3 utils/validate_perf_changelog.py --changelog-file perf-changelog.yaml --base-ref origin/main --head-ref HEAD
  • python3 -m pytest utils/test_process_changelog.py utils/matrix_logic/test_generate_sweep_configs.py -q (116 passed)
  • Generated AIPerf command includes the backend URL after --server-metrics.
  • git diff --check

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@cquil11
cquil11 force-pushed the agent/refresh-dsv4-b200-vllm-agentic-mtp branch from b9a8538 to 045fee2 Compare August 7, 2026 05:12
@cquil11
cquil11 marked this pull request as ready for review August 7, 2026 05:24
@cquil11
cquil11 requested a review from a team August 7, 2026 05:24
@claude

claude Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @cquil11's task in 1m 29s —— View job


Review

  • Gather context (diff vs origin/main)
  • Verify new perf-changelog.yaml entry is appended at end of file
  • Validate entry format and referenced config key
  • Post review summary

LGTM - no blocking issues found

Verified: the new entry is appended at the end of perf-changelog.yaml (chronological order preserved), the referenced config key dsv4-fp4-b200-vllm-agentic-mtp exists in configs/nvidia-master.yaml, scenario-type: agentic-coding matches existing entries, and git diff --check passes.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — trivial changelog-only entry, matches the pattern of the immediately preceding commit.

Extended reasoning...

Overview

The PR adds a single new entry to perf-changelog.yaml documenting a harness refresh for the dsv4-fp4-b200-vllm-agentic-mtp config. No code, harness scripts, or master-config files are touched.

Security risks

None. The change is a static YAML changelog entry with a description string and a PR link; it contains no executable code, credentials, or config that affects runtime behavior.

Level of scrutiny

Minimal scrutiny is warranted. This is a documentation/metadata-only change to a changelog file, and it follows the exact same shape as the immediately preceding commit (045fee2) which added an analogous entry for the sibling dsv4-b200-vllm-agentic-mtp config. I confirmed the referenced config key dsv4-fp4-b200-vllm-agentic-mtp exists in configs/nvidia-master.yaml, so the changelog entry points at a real, valid config.

Other factors

No prior reviews exist on this PR from me. The bug-hunting system found no issues, and the one candidate concern raised (changelog claims a harness refresh without an accompanying code change) was verified as consistent with existing repo convention, where the actual harness/image bump lands in a separate commit and this PR only adds the changelog record.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@cquil11

cquil11 commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

/stage-results 31192602558

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@cquil11 staged run 31192602558: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-08-07~r31192602558

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@cquil11 已将运行 31192602558 发布到预发布环境:https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-08-07~r31192602558

后续的 /stage-results 请求不会移除此运行;再次发布相同的运行 ID 会更新其预发布数据。预发布工作流

@cquil11

cquil11 commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run 31192602558

@cquil11
cquil11 merged commit c341142 into main Aug 8, 2026
26 checks passed
@cquil11
cquil11 deleted the agent/refresh-dsv4-b200-vllm-agentic-mtp branch August 8, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant