Repository navigation
[Klaud Cold] minimaxm3-fp8-gb300-dynamo-vllm-mtp: day-zero GB300 MXFP8 EAGLE3 MTP + FULL_DECODE_ONLY CG / 新增 GB300 MXFP8 EAGLE3 MTP 配方，解码启用 FULL_DECODE_ONLY 图模式 - #2486
Merged
functionstackx merged 4 commits intoAug 4, 2026
Claude / Claude Code Review
completed
Aug 4, 2026 in 9m 18s
Code review found 1 important issue
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | benchmarks/multi_node/srt-slurm-recipes/vllm/minimax-m3-gb300-fp8/8k1k/mtp/1p1d-dep2-tp4-eagle3-c1-8k1k.yaml:104 |
cudagraph_mode set as bare top-level key instead of via compilation-config JSON |
| 🟡 Nit | perf-changelog.yaml:5428-5443 |
perf-changelog.yaml entries reference wrong PR number (#2478 instead of #2486) |
Annotations
claude / Claude Code Review
cudagraph_mode set as bare top-level key instead of via compilation-config JSON
All 11 new decode `vllm_config` blocks in this PR set `cudagraph_mode: FULL_DECODE_ONLY` as a bare top-level key (e.g. line 104 in `1p1d-dep2-tp4-eagle3-c1-8k1k.yaml`, and the same line in the other 10 sibling files), but every other recipe in this repo enables that mode by embedding it inside the `compilation-config` JSON blob (e.g. `compilation-config: '{"cudagraph_mode":"FULL_DECODE_ONLY",...}'`). Since srt-slurm passes top-level `vllm_config` keys through as `--<key>` CLI flags, this likely
Check warning on line 5443 in perf-changelog.yaml
claude / Claude Code Review
perf-changelog.yaml entries reference wrong PR number (#2478 instead of #2486)
Both new perf-changelog.yaml entries for `minimaxm3-fp8-gb300-dynamo-vllm-mtp` link to PR #2478 instead of #2486, which is the PR actually landing this config-key on main (#2478 is still open/unmerged). Every other entry in the file points to its own introducing PR, so this reads as a stale reference carried over from the source branch; it should point to #2486. The entries also don't mention the `cudagraph_mode: FULL_DECODE_ONLY` addition, which is this PR's headline change.
Loading