Skip to content

[Klaud Cold][agentic experiment][Variant D] Kimi-K3 B200 agg TP8xPP2 agentic — direct vllm serve (srt-slurm PR 278) / Kimi-K3 B200 聚合式 TP8xPP2 智能体实验——直接 vllm serve(srt-slurm PR 278) - #2359

Closed
functionstackx wants to merge 17 commits into
mainfrom
klaud/kimik3-b200-agentic-direct-vllm

feat: agentic experiment D — direct vllm serve via srt-slurm PR #278

8fd319c
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 27, 2026 in 18m 28s

Code review found 2 potential issues

Found 4 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml:118-127 No-Dynamo recipe silently defeats agentic_srt.sh inter-concurrency drain wait
🟡 Nit benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml:37-39 Recipe's max_attempts:1440 health-check budget silently clobbered to 720 by launcher sed

Annotations

Check warning on line 127 in benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml

See this annotation in the file changed.

@claude claude / Claude Code Review

No-Dynamo recipe silently defeats agentic_srt.sh inter-concurrency drain wait

This recipe is the first to pair the shared `agentic_srt.sh` inter-concurrency drain wait (which polls for the Dynamo-only metric `dynamo_frontend_active_requests`) with a no-Dynamo, direct-`vllm serve` frontend that never emits it, so the idle check is vacuously true from the first poll. It's dormant today because `conc-list` is a single point `[8]` (the drain wait only runs between points), but the recipe's own comment says the curve will be widened later — at that point later concurrency poin

Check warning on line 39 in benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml

See this annotation in the file changed.

@claude claude / Claude Code Review

Recipe's max_attempts:1440 health-check budget silently clobbered to 720 by launcher sed

The launcher's pre-existing sed at runners/launch_b200-dgxc.sh:300 (`sed -i 's/^  max_attempts: [0-9]*/  max_attempts: 720/'`) unconditionally rewrites this recipe's `health_check.max_attempts: 1440` (4h) down to 720 (2h) before every `srtctl apply`, since the recipe line matches the 2-space-indent regex. This is pre-existing launcher behavior surfaced by this PR's recipe, not a bug the PR introduces — and in this specific recipe it's inert since `VLLM_ENGINE_READY_TIMEOUT_S: 3600` (1h) already