Repository navigation
[Klaud Cold][agentic experiment][Variant A] feat: add Kimi-K3 MXFP4 B200 aggregated TP8xPP2 Dynamo-vLLM agentic bring-up / 新增 Kimi-K3 MXFP4 B200 聚合式 TP8xPP2 Dynamo-vLLM 智能体编码基准测试（bring-up） - #2355
Closed
functionstackx wants to merge 11 commits into
Claude / Claude Code Review
completed
Jul 27, 2026 in 8m 45s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | benchmarks/multi_node/srt-slurm-recipes/vllm/kimi-k3/agentic/agg-b200-tp8pp2-agentic.yaml:33-34 |
Launcher clobbers recipe's 4h health-check timeout back to 2h |
Annotations
claude / Claude Code Review
Launcher clobbers recipe's 4h health-check timeout back to 2h
The recipe deliberately sets `health_check.max_attempts: 1440` (4h) for the ~1.4TB Kimi-K3 MXFP4 checkpoint, but `runners/launch_b200-dgxc.sh:291` unconditionally runs `sed -i 's/^ max_attempts: [0-9]*/ max_attempts: 720/'` on the copied config right before `srtctl apply`, silently clobbering it back to 720 attempts (2h) — the same budget sized for DSR1-FP8 at roughly half this checkpoint's weight size. The recipe file will look correctly configured but the wider window never actually takes ef
Loading