[Klaud Cold] docs: refer to InferenceX-e2e in MODELS doc / MODELS 文档改用 InferenceX-e2e 名称 #2344
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MODELS.md and MODELS_zh.md now say the doc tracks models benchmarked by "InferenceX-e2e" instead of "InferenceX", but this term appears nowhere else in the repo (README.md, AGENTS.md, and 28+ other docs all use the unsuffixed "InferenceX") and is not defined anywhere. Worth confirming this rename is intentional (and should propagate elsewhere) before merging, since it could just as easily be an automation artifact.
Extended reasoning...
What changed
The diff swaps a single word in the intro sentence of
MODELS.md/MODELS_zh.md: "benchmarked by InferenceX" → "benchmarked by InferenceX-e2e". Nothing else in either file, or anywhere else in the repo, changes.Why this is worth flagging despite being the PRs stated intent
The PR title and description do say this substitution is the entire point of the change ("MODELS doc now says ... InferenceX-e2e instead of InferenceX"), so on its face this is not an accidental typo the author overlooked mid-edit — it is the deliberate diff. I take that objection seriously and it is the reason I am not marking this
normal.But "the PR description matches the diff" is a different question from "the term is correct." A grep across the entire repository for
InferenceX-e2ereturns exactly the two lines this PR touches — zero other hits. Meanwhile the canonical nameInferenceXappears 225+ times across README.md (# InferenceX™, Open Source Continuous Inference Standard), AGENTS.md ("InferenceX is an open-source automated benchmarking system..."), CONTRIBUTING.md, and every other doc in the repo. Results are published toinferencex.com, and the repo itself isSemiAnalysisAI/InferenceX. No workflow, script, or doc anywhere defines an entity called "InferenceX-e2e" or explains how it would differ from InferenceX (e.g., a distinct end-to-end test harness vs. the umbrella benchmarking project).This PR is tagged
[Klaud Cold], i.e., produced by an automated docs-maintenance agent, not a human author making a considered product-naming decision. For that class of change, "the diff matches the PR description" only tells you the agent executed its own plan faithfully — it does not tell you the plan itself was sound. A one-word rename to a brand/product name that (a) is unique to two lines in the whole repo, (b) has no definition anywhere, and (c) contradicts the same name used in README.md and AGENTS.md is a classic shape for an LLM-introduced hallucination/drift that happens to be internally consistent with its own PR description, since the agent wrote both.Step-by-step proof
grep -rn "InferenceX-e2e" .→ onlyMODELS.md:5andMODELS_zh.md:5(this PRs two changed lines).grep -rn "InferenceX" README.md | head -1→# InferenceX™, Open Source Continuous Inference Standard— confirms the canonical, trademarked name has no-e2esuffix.grep -n "InferenceX is" AGENTS.md→InferenceX is an open-source automated benchmarking system...— the repos own architecture doc, unmodified by this PR, still uses the unsuffixed name.InferenceX-e2e, so a reader of MODELS.md landing on this sentence has no way to resolve what makes it different from the InferenceX defined two clicks away in README.md.Suggested resolution
Before merging, confirm whether "InferenceX-e2e" is an intentional new term that should be introduced (with a definition) and propagated consistently, or whether it should simply read "InferenceX" to match the rest of the repo. Given the total absence of the term elsewhere, reverting to "InferenceX" is the safer default absent an explicit definition.