Deprecate 1k1k benchmark configurations - #2263
Merged
Merged
Conversation
adibarra
requested review from
1am9trash,
billishyahao,
chunfangamd,
seungrokj and
yctseng0211
as code owners
July 18, 2026 01:48
Contributor
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
8 tasks
This was referenced Jul 27, 2026
This was referenced Jul 29, 2026
Ankur-singh
added a commit
that referenced
this pull request
Aug 6, 2026
…-trt / 移除已弃用的 Single-turn 1k1k 场景 Single-turn 1k1k (isl 1024 / osl 1024) is deprecated for all models since 2026-07-17 (#2263) per MODELS.md, and the deprecation was enacted on 2026-08-04 by #2493, which removed 54 config keys from the active master configs. This submission still added a 1k1k scenario, so it is removed here. - Delete the 9 disagg 1k1k STP recipes under benchmarks/multi_node/srt-slurm-recipes/trtllm/qwen3.5/gb300-fp4/disagg/1k1k/ - Remove the isl 1024 / osl 1024 scenario (9 search-space points) from the qwen3.5-fp4-gb300-dynamo-trt block in configs/nvidia-master.yaml - Align the perf-changelog entry to describe an 8k1k-only submission The Single-turn 8k1k half is unchanged: 9 recipes and 9 search-space points remain byte-identical. 中文：根据 MODELS.md，Single-turn 1k1k（isl 1024 / osl 1024）自 2026-07-17 起对所有模型弃用（#2263），并已于 2026-08-04 由 #2493 正式执行（从活跃主配置中 移除了 54 个 config key）。本次提交仍新增了 1k1k 场景，故在此移除：删除 gb300-fp4/disagg/1k1k/ 下的 9 个 STP recipe，从 configs/nvidia-master.yaml 的 qwen3.5-fp4-gb300-dynamo-trt 块中删除 isl 1024 / osl 1024 场景及其 9 个搜索空间 配置点，并同步修改 perf-changelog 描述为仅 8k1k。Single-turn 8k1k 部分保持不变， 9 个 recipe 与 9 个搜索空间配置点逐字节保留。
adibarra
added a commit
that referenced
this pull request
Aug 10, 2026
…arks / [NVIDIA] 添加 GB300 Qwen3.5 NVFP4 Dynamo-TensorRT-LLM 分离式基准测试 (#2206) * add dynamo trtllm gb300 qwen3.5 nvfp4 recipes * update PR link * update PR link * fix no preflight * chore: drop deprecated Single-turn 1k1k from qwen3.5-fp4-gb300-dynamo-trt / 移除已弃用的 Single-turn 1k1k 场景 Single-turn 1k1k (isl 1024 / osl 1024) is deprecated for all models since 2026-07-17 (#2263) per MODELS.md, and the deprecation was enacted on 2026-08-04 by #2493, which removed 54 config keys from the active master configs. This submission still added a 1k1k scenario, so it is removed here. - Delete the 9 disagg 1k1k STP recipes under benchmarks/multi_node/srt-slurm-recipes/trtllm/qwen3.5/gb300-fp4/disagg/1k1k/ - Remove the isl 1024 / osl 1024 scenario (9 search-space points) from the qwen3.5-fp4-gb300-dynamo-trt block in configs/nvidia-master.yaml - Align the perf-changelog entry to describe an 8k1k-only submission The Single-turn 8k1k half is unchanged: 9 recipes and 9 search-space points remain byte-identical. 中文：根据 MODELS.md，Single-turn 1k1k（isl 1024 / osl 1024）自 2026-07-17 起对所有模型弃用（#2263），并已于 2026-08-04 由 #2493 正式执行（从活跃主配置中 移除了 54 个 config key）。本次提交仍新增了 1k1k 场景，故在此移除：删除 gb300-fp4/disagg/1k1k/ 下的 9 个 STP recipe，从 configs/nvidia-master.yaml 的 qwen3.5-fp4-gb300-dynamo-trt 块中删除 isl 1024 / osl 1024 场景及其 9 个搜索空间 配置点，并同步修改 perf-changelog 描述为仅 8k1k。Single-turn 8k1k 部分保持不变， 9 个 recipe 与 9 个搜索空间配置点逐字节保留。 * Correct kv-p2p-transfer metadata and the srt-slurm changelog reference Two label defects, no behaviour change: - configs/nvidia-master.yaml declared kv-p2p-transfer: nixl, but all nine retained recipes set cache_transceiver_config.backend: UCX on both prefill and decode. That value is propagated verbatim into every result row as kv_p2p_transfer, so each published point was labelled NIXL while running UCX. Corrected to ucx to describe what actually runs. - The perf-changelog entry said the runner clones srt-slurm@sa-submission-q2-2026 while launch_gb300-nv.sh checks out the immutable tag v1.0.29 on this path. Corrected, and the --no-preflight change this PR also makes is now recorded. --------- Co-authored-by: Ankur-singh <ankusingh@nvidia.com> Co-authored-by: adibarra <93070681+adibarra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed, the time has come to deprecate 1k1k. 🫡
Summary
configs/deprecated/nvidia-1k1k-master.yamlconfigs/deprecated/amd-1k1k-master.yamlVerification
0fixed-sequence 1k1k jobs.1,883fixed-sequence 8k1k jobs.1,831fixed-sequence 1k1k jobs.