Claude / Claude Code Review
completed
Jul 14, 2026 in 13m 50s
Code review found 1 important issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | benchmarks/single_node/agentic/dsv4_fp4_b200_vllm.sh:111-120 |
B200 vllm-simple KV offload config: wrong extra_config key and known-broken lazy_offload value |
Annotations
Check failure on line 120 in benchmarks/single_node/agentic/dsv4_fp4_b200_vllm.sh
claude / Claude Code Review
B200 vllm-simple KV offload config: wrong extra_config key and known-broken lazy_offload value
The new B200 vllm-simple KV-offload config (line 118) hardcodes `lazy_offload:false`, which per this repo's own note in `kimik2.5_int4_h200.sh:47-49` is known to hit a `popleft_n` AssertionError at low/mid CONC specifically for DSv4 + SimpleCPUOffloadConnector — exactly the combo and CONC range (8-72) swept here. It also uses key `cpu_bytes_to_use_per_rank` instead of the connector's documented `cpu_bytes_to_use` key used everywhere else (kimik2.5 and the B300 sibling in this same PR), which lik
Loading