[AMD][ATOM] KIMI fp4 MI355 update docker - #2132
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Claude finished @benenzhu's task in 3m 35s —— View job Review: KIMI fp4 MI355 recipe update
Findings1 blocking issue (inline comment): the new 1 warning (inline comment): Notes
|
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=29033878626 |
Co-authored-by: Felix Li <felix.li@amd.com> Co-authored-by: valarLip <ljin1@amd.com>
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=29067856301 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=29068018278 |
|
Recipes updated at ROCm/ATOM#1566 |
|
/reuse-sweep-run |
chunfangamd
left a comment
There was a problem hiding this comment.
As a PR reviewer and CODEOWNER, I have reviewed this and have:
- Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
- Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
- Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/29068018278
- Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Range: 97.19%-97.27%; link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/29068018278
- Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
- For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
- Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
- If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
- If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
- Verified that the single-node recipes are similar to the official vLLM recipes and/or theSGLang cookbook:
- If they are not, I have verified that a PR has been opened in vLLM recipe repo or SGLang repo and linked it below in the additional detail section:
- Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/
<PR_NUMBER>.md— named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section. - If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.
Additional detail section:
- insert any additional info here
Signed: @chunfangamd
❌❌❌ REJECTED ❌❌❌@chunfangamd — blocking issue: the sign-off's additional detail section is the unedited template placeholder, so the single-node recipe link is missing and the unchecked recipe checklist items have no explanation. Please post a fresh sign-off with the recipe source linked and reasoned in the additional detail section. ✅ Check 0 (CODEOWNER): PASS — @chunfangamd is a listed owner of |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:
Signed: @chunfangamd |
✅✅✅ Verdict: PASS ✅✅✅Updated verdict for this head SHA: the earlier rejection was solely about the sign-off's placeholder additional-detail section; the fresh sign-off links the recipe and checks the recipe items, and everything re-verifies green. ✅ Check 0 (CODEOWNER): PASS — @chunfangamd is a listed owner of |
co-author-by: Readonflow Team(@ColorsWind, @ftyghome, @jpy794) , @valarLip, @coderfeli, @Bernard-Liu
Related PRs:
[PERF] MXFP4 (a4w4) MoE backend for gfx950 by ColorsWind · Pull Request #3470 · ROCm/aiter
[RadeonFlow] MXFP4 (a4w4) MoE backend for gfx950 by coderfeli · Pull Request #3832 · ROCm/aiter
perf: optimize topk kernel by ftyghome · Pull Request #3466 · ROCm/aiter
perf: raise fused ar 1stage limit to cover conc64 by ftyghome · Pull Request #3458 · ROCm/aiter
[PERF] fix: Correct AR 1stage Gating Condition by ftyghome · Pull Request #3880 · ROCm/aiter
perf: add mla metadata parallel path by ftyghome · Pull Request #3465 · ROCm/aiter
Other performance-related PRs may have been missed here; please feel free to ping me to add them.