Repository navigation
[AMD] Minimax-M3-MXFP8 Eagle3 Draft attention backend override TRITON_ATTN for performance/Minimax-M3-MXFP8 Eagle3草稿模型的注意力后端固定为 TRITON_ATTN以提高性能 - #2107
Merged
Claude / Claude Code Review
completed
Jul 6, 2026 in 5m 32s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | perf-changelog.yaml:4581 |
Changelog description has broken grammar |
| 🟡 Nit | benchmarks/single_node/fixed_seq_len/minimaxm3_fp8_mi355x_mtp.sh:3 |
PR title and body missing Chinese translations |
Annotations
Check warning on line 4581 in perf-changelog.yaml
claude / Claude Code Review
Changelog description has broken grammar
The changelog description reads ungrammatically: "Pin the EAGLE3 drafter to TRITON_ATTN via the speculative-config attention_backend override (and otherwise falls to a slow default backend)". The parenthetical has no clear subject (it grafts onto 'Pin the EAGLE3 drafter', so it reads as 'Pin ... otherwise falls to...') and 'falls to' should be 'falls back to'. Suggested rewrite: "Pin the EAGLE3 drafter to TRITON_ATTN via the speculative-config attention_backend override; without it the drafter f
Check warning on line 3 in benchmarks/single_node/fixed_seq_len/minimaxm3_fp8_mi355x_mtp.sh
claude / Claude Code Review
PR title and body missing Chinese translations
PR title and description are English-only, but AGENTS.md line 7 requires bilingual metadata on every PR — title format `<English title> / <中文标题>` and a `## 中文说明` section (or equivalent) mirroring the body. Please amend the title to append a Simplified Chinese translation after `/` and add a `## 中文说明` section to the description summarizing the change (e.g. pinning the EAGLE3 drafter attention backend to TRITON_ATTN for a throughput win).
Loading