Skip to content

Update Minimax M3 B300 FP4 vllm - #1994

Merged
functionstackx merged 6 commits into
mainfrom
wzhao/minimax-m3-b300-fp4
Jul 6, 2026
Merged

functionstackx merged 6 commits into
mainfrom
wzhao/minimax-m3-b300-fp4

Modify nvidia-master.yaml for model configurations

105b782
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 3, 2026 in 14m 26s

Code review found 1 important issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important perf-changelog.yaml:4435-4436 Trailing whitespace on separator line breaks merge_with_reuse.sh canonicalize step

Annotations

Check failure on line 4436 in perf-changelog.yaml

See this annotation in the file changed.

@claude claude / Claude Code Review

Trailing whitespace on separator line breaks merge_with_reuse.sh canonicalize step

The new perf-changelog entry uses a separator line with two trailing spaces (`  \n`) at line 4436 instead of a truly-empty line. This will abort `utils/merge_with_reuse.sh` at the `prepare_perf_changelog_merge.py canonicalize` step with `ChangelogValidationError: new changelog entries must be separated from history by one empty line and appended at the end`. Strip the two trailing spaces on line 4436 so the separator is just `\n`.