Repository navigation
[NV] perf: update MiniMax-M3 FP4 B300 vLLM - #1990
Merged
Merged
Claude / Claude Code Review
completed
Jul 2, 2026 in 4m 58s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | perf-changelog.yaml:4430-4435 |
perf-changelog entry: branch pr-link and misleading description |
| 🟡 Nit | .github/configs/nvidia-master.yaml:12812 |
Stale comment references perf container image after switch to nightly |
Annotations
Check warning on line 4435 in perf-changelog.yaml
claude / Claude Code Review
perf-changelog entry: branch pr-link and misleading description
The new `perf-changelog.yaml` entry has two issues: (1) `pr-link` uses a branch URL (`tree/codex/minimax-m3-b300-fp4-vllm-update`) instead of the canonical `pull/1990` form used by every other entry in the file — this will 404 once the branch is deleted after merge; (2) the description says "Update search space to cover more configs", but the diff actually narrows the sweep (isl 1024: 7→4 entries, isl 8192: 6→4 entries, all TP8/EP8 and TP4/EP4 lanes dropped). Consider phrasing similar to the nei
Check warning on line 12812 in .github/configs/nvidia-master.yaml
claude / Claude Code Review
Stale comment references perf container image after switch to nightly
The block comment just above this line still says the NVFP4 support 'is baked into the perf container image', but the PR swaps the image from the bespoke `vllm-minimax-m3-perf-*` tag to a mainline `nightly-*` tag. Update the comment to say the support has landed in vLLM main and is picked up from nightly so future readers don't chase a nonexistent perf image. Note: the same wording appears at lines 12839-12840 for the EAGLE3 variant (whose image is NOT changed in this PR), so that comment remain
Loading