Repository navigation
[AMD] Update MiniMax-M3 FP4 MI355X ATOM image and serving args (0630) - #1967
Merged
Merged
Claude / Claude Code Review
completed
Jul 1, 2026 in 8m 37s
Code review found 1 important issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | perf-changelog.yaml:4362 |
perf-changelog pr-link left as PLACEHOLDER |
Annotations
Check failure on line 4362 in perf-changelog.yaml
claude / Claude Code Review
perf-changelog pr-link left as PLACEHOLDER
The new perf-changelog entry appended for this PR sets `pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PLACEHOLDER` — a literal, un-substituted token. The changelog validator (`utils/validate_perf_changelog.py`) only accepts the canonical `/pull/<digits>` URL or the sentinel `XXX` / `.../pull/XXX`; `PLACEHOLDER` is neither, so `utils/prepare_perf_changelog_merge.py` will raise `appended entry N has unexpected pr-link` and block merge. Replace it with `1967` (or `XXX` to hit the auto-
Loading