Repository navigation
[codex] update MiniMax M3 FP8 MI355X vLLM MTP image - #1941
Merged
functionstackx merged 1 commit intoJun 26, 2026
Merged
Claude / Claude Code Review
completed
Jun 26, 2026 in 12m 9s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | .github/configs/amd-master.yaml:2565 |
Image bump leaves stale in-place EAGLE3 patch in FP8 MTP recipe |
Annotations
Check failure on line 2565 in .github/configs/amd-master.yaml
claude / Claude Code Review
Image bump leaves stale in-place EAGLE3 patch in FP8 MTP recipe
Image bumps minimaxm3-fp8-mi355x-vllm-mtp to nightly-3f5a1e17... but benchmarks/single_node/fixed_seq_len/minimaxm3_fp8_mi355x_mtp.sh:18-25,89-167 was not updated — it still hard-codes the old vllm/vllm-openai-rocm:minimax-m3 image in the docstring and runs an in-place EAGLE3 patch with a sys.exit hard-fail if any anchor count != 1. The FP4 sibling minimaxm3_fp4_mi355x_vllm_mtp.sh:6-7 uses the IDENTICAL nightly and explicitly states 'The pinned nightly includes upstream AMD MiniMax-M3 SupportsEa
Loading