Update gptoss-fp4-mi300x-vllm vLLM image to v0.20.2 - #1349
Closed
Klaud-Cold wants to merge 1 commit into
Closed
Klaud-Cold wants to merge 1 commit into
Klaud-Cold wants to merge 1 commit into
Claude / Claude Code Review
completed
May 16, 2026 in 3m 46s
Code review found 1 important issue
Found 6 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | perf-changelog.yaml:2347-2351 |
Placeholder pr-link XXX in changelog entry |
| 🟡 Nit | .github/configs/amd-master.yaml:705 |
PR title says v0.21.0 but image is pinned to v0.20.2 |
Annotations
Check failure on line 2351 in perf-changelog.yaml
claude / Claude Code Review
Placeholder pr-link XXX in changelog entry
The new perf-changelog entry at line 2351 uses `pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX` with a literal `XXX` placeholder that was never replaced with the actual PR number. After merge this link will 404 and the changelog entry will be permanently broken. Please update to `/pull/1403` before merging.
Check warning on line 705 in .github/configs/amd-master.yaml
claude / Claude Code Review
PR title says v0.21.0 but image is pinned to v0.20.2
The PR title says "Update gptoss-fp4-mi300x-vllm vLLM ROCm image to v0.21.0" and the description says the update is from v0.17.0 to v0.21.0, but the diff (this line and the perf-changelog entry) actually pins the image to `v0.20.2`. The yaml, changelog, and commit message (91b6c49) are internally consistent on v0.20.2, so this looks like a stale PR title/description — please either amend the title/description to v0.20.2, or bump the image tag to v0.21.0 if that was the intent.
Loading