Add SGLANG_OPT_USE_MULTI_STREAM_OVERLAP=1 to SGLang DSv4 launch configs#1246
Closed
yhyang201 wants to merge 2 commits into
Closed
Add SGLANG_OPT_USE_MULTI_STREAM_OVERLAP=1 to SGLang DSv4 launch configs#1246yhyang201 wants to merge 2 commits into
yhyang201 wants to merge 2 commits into
Claude / Claude Code Review
completed
May 1, 2026 in 5m 48s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | benchmarks/single_node/dsv4_fp4_b200.sh:30 |
Missing perf-changelog.yaml entry for env-var change |
Annotations
Check warning on line 30 in benchmarks/single_node/dsv4_fp4_b200.sh
claude / Claude Code Review
Missing perf-changelog.yaml entry for env-var change
This PR enables `SGLANG_OPT_USE_MULTI_STREAM_OVERLAP=1` across 9 SGLang DSv4 launch configs (a perf-affecting toggle) but does not add a corresponding entry to `perf-changelog.yaml`. AGENTS.md (Updating Docker Images section) lists this as a **MUST** for env-var/configuration changes so that `run-sweep.yml` is triggered on push-to-main and the perf delta is captured. Please add a perf-changelog entry covering `dsv4-fp4-b200-sglang`, `dsv4-fp4-b300-sglang*`, and the disaggregated GB300 SGLang con
Loading