Increase timeout#1148
Merged
Merged
Claude / Claude Code Review
completed
Apr 25, 2026 in 4m 49s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | perf-changelog.yaml:1798-1805 |
Duplicate changelog entry for dsv4-fp8-mi355x-sglang |
Annotations
Check warning on line 1805 in perf-changelog.yaml
claude / Claude Code Review
Duplicate changelog entry for dsv4-fp8-mi355x-sglang
This new entry duplicates the block added by PR #1147 (immediately above at lines 1790-1796) — all four description bullets are verbatim copies. Since PR #1148's diff only modifies perf-changelog.yaml and does not touch `runners/launch_mi355x-amds.sh`, the bullet "Bump MI355X SLURM allocation from --time=180 to --time=300" misrepresents what this PR actually does. Consider replacing the four bullets with a single `Retriggering dsv4-fp8-mi355x-sglang` bullet (matching the convention at line 1727
Loading