Bump MI355X SLURM time-limit to 300m; retrigger dsv4-fp8-mi355x-sglang#1147
Merged
Claude / Claude Code Review
completed
Apr 25, 2026 in 4m 42s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | perf-changelog.yaml:1789-1796 |
Missing pr-link field in new changelog entry will fail validation |
Annotations
Check failure on line 1796 in perf-changelog.yaml
claude / Claude Code Review
Missing pr-link field in new changelog entry will fail validation
The new changelog entry for `dsv4-fp8-mi355x-sglang` at perf-changelog.yaml:1790-1796 is missing the required `pr-link` field. The pydantic `ChangelogEntry` model in `utils/matrix_logic/validation.py:338-345` declares `pr_link` as required with no default and uses `extra="forbid"`, so `utils/process_changelog.py` will raise a ValidationError when this PR's changelog is processed, breaking the run-sweep CI this PR exists to retrigger. Fix by adding `pr-link: https://github.com/SemiAnalysisAI/Infe
Loading