chore: tag dsv4 b300 benchmark scripts with inference engine #1146
Claude / Claude Code Review
completed
Apr 24, 2026 in 9m 57s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | benchmarks/single_node/dsv4_fp4_b300_vllm.sh:3-5 |
Misleading comment: claims to mirror dsv4_fp4_b200.sh which is actually an SGLang script |
Annotations
Check warning on line 5 in benchmarks/single_node/dsv4_fp4_b300_vllm.sh
claude / Claude Code Review
Misleading comment: claims to mirror dsv4_fp4_b200.sh which is actually an SGLang script
The header comment claims this script "mirrors dsv4_fp4_b200.sh" since the vLLM blog lists 8xB200 and 8xB300 with identical flags, but `dsv4_fp4_b200.sh` is an SGLang script (uses `sglang serve` with SGLang-specific flags like `--moe-runner-backend`, `--moe-a2a-backend deepep`, CONC-based recipe dispatch). This new script uses `vllm serve` with an entirely different flag set and a vLLM-specific monkey-patch — they share no engine or flags. Consider dropping the `mirrors dsv4_fp4_b200.sh` referen
Loading