Add dsv4-fp8-h200-sglang single-node config #1136
Closed
Claude / Claude Code Review
completed
Apr 24, 2026 in 9m 1s
Code review found 1 important issue
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | runners/launch_h200-cw.sh:14-23 |
Missing /ix mount workaround in launch_h200-dgxc-slurm.sh |
| 🟡 Nit | perf-changelog.yaml:1-9 |
perf-changelog.yaml entry prepended instead of appended |
Annotations
Check failure on line 23 in runners/launch_h200-cw.sh
claude / Claude Code Review
Missing /ix mount workaround in launch_h200-dgxc-slurm.sh
The /ix mount workaround is applied to launch_h200-cw.sh and launch_h200-nb.sh but not to runners/launch_h200-dgxc-slurm.sh. Per .github/configs/runners.yaml, 14 of the 18 h200 pool runners are h200-dgxc-slurm_*, so the new dsv4-fp8-h200-sglang config (declared as runner: h200) will most often be scheduled onto the unfixed launcher, where /workspace bind-mount will mask /workspace/sglang/python and `import sglang` will fail — the exact failure this PR is trying to prevent. Apply the same conditi
Check warning on line 9 in perf-changelog.yaml
claude / Claude Code Review
perf-changelog.yaml entry prepended instead of appended
The new dsv4-fp8-h200-sglang entry was prepended at lines 1-9 of `perf-changelog.yaml`, but AGENTS.md requires new entries to be appended to the END of the file. Please move this entry to the bottom of the file, alongside the other recent entries (e.g., #1043, #1120).
Loading