Skip to content

[AMD] Tune dsr1-fp8-mi355x-sglang: --num-continuous-decode-steps 4 → 8 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lishuoshuo-amd wants to merge 2 commits into from

fix: update dsr1_fp8_mi355x

b10c872
Select commit
Loading
Failed to load commit list.
Closed

[AMD] Tune dsr1-fp8-mi355x-sglang: --num-continuous-decode-steps 4 → 8 #1109

fix: update dsr1_fp8_mi355x
b10c872
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 1, 2026 in 3m 26s

Code review found 1 important issue

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important perf-changelog.yaml:1-6 perf-changelog.yaml entry has wrong pr-link and wrong location

Annotations

Check failure on line 6 in perf-changelog.yaml

See this annotation in the file changed.

@claude claude / Claude Code Review

perf-changelog.yaml entry has wrong pr-link and wrong location 

The new perf-changelog.yaml entry has two issues: (1) **pr-link points to the wrong PR** — it references #1109 (an unrelated older PR) instead of this PR (#1243); (2) **the entry is prepended to the top of the file** instead of appended to the end, violating the explicit rule in AGENTS.md (line 161): "New entries MUST be appended to the END of the file — never insert in the middle or prepend." Please update the pr-link to https://github.com/SemiAnalysisAI/InferenceX/pull/1243 and move the new YA
View more details on Claude