-
Notifications
You must be signed in to change notification settings - Fork 161
Add B300 config: kimi-k2.5-int4-vllm #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # NOTE: At the time of submission, https://docs.vllm.ai/projects/recipes/en/latest/moonshotai/Kimi-K2.5.html | ||
| # does not have a B300-specific recipe, so this script reuses the existing | ||
| # Kimi-K2.5 INT4 B200 vLLM recipe as-is until B300-specific tuning is available. | ||
|
|
||
| source "$(dirname "$0")/../benchmark_lib.sh" | ||
|
|
||
| check_env_vars \ | ||
| MODEL \ | ||
| TP \ | ||
| CONC \ | ||
| ISL \ | ||
| OSL \ | ||
| MAX_MODEL_LEN \ | ||
| RANDOM_RANGE_RATIO \ | ||
| RESULT_FILENAME | ||
|
|
||
| if [[ -n "$SLURM_JOB_ID" ]]; then | ||
| echo "JOB $SLURM_JOB_ID running on $SLURMD_NODENAME" | ||
| fi | ||
|
|
||
| hf download "$MODEL" | ||
|
|
||
| nvidia-smi | ||
|
|
||
| export PYTHONNOUSERSITE=1 | ||
| export VLLM_USE_FLASHINFER_MOE_INT4=1 | ||
|
|
||
| SERVER_LOG=/workspace/server.log | ||
| PORT=${PORT:-8888} | ||
|
|
||
| if [ "${EVAL_ONLY}" = "true" ]; then | ||
| setup_eval_context | ||
| MAX_MODEL_LEN="$EVAL_MAX_MODEL_LEN" | ||
| fi | ||
| # Start GPU monitoring (power, temperature, clocks every second) | ||
| start_gpu_monitor | ||
|
|
||
| set -x | ||
| vllm serve $MODEL --host 0.0.0.0 --port $PORT \ | ||
| --gpu-memory-utilization 0.95 \ | ||
| --tensor-parallel-size $TP \ | ||
| --max-model-len $MAX_MODEL_LEN \ | ||
| --max-num-seqs $CONC \ | ||
| --reasoning-parser kimi_k2 \ | ||
| --tool-call-parser kimi_k2 \ | ||
| --compilation_config.pass_config.fuse_allreduce_rms true \ | ||
| --trust-remote-code \ | ||
| --disable-log-requests \ | ||
| --no-enable-prefix-caching > $SERVER_LOG 2>&1 & | ||
|
|
||
| SERVER_PID=$! | ||
|
|
||
| # Wait for server to be ready | ||
| wait_for_server_ready --port "$PORT" --server-log "$SERVER_LOG" --server-pid "$SERVER_PID" | ||
|
|
||
| pip install -q datasets pandas | ||
|
|
||
| run_benchmark_serving \ | ||
| --model "$MODEL" \ | ||
| --port "$PORT" \ | ||
| --backend vllm \ | ||
| --input-len "$ISL" \ | ||
| --output-len "$OSL" \ | ||
| --random-range-ratio "$RANDOM_RANGE_RATIO" \ | ||
| --num-prompts $(( CONC * 10 )) \ | ||
| --max-concurrency "$CONC" \ | ||
| --result-filename "$RESULT_FILENAME" \ | ||
| --result-dir /workspace/ \ | ||
| --trust-remote-code | ||
|
|
||
| # After throughput, run evaluation only if RUN_EVAL is true | ||
| if [ "${RUN_EVAL}" = "true" ]; then | ||
| run_eval --framework lm-eval --port "$PORT" | ||
| append_lm_eval_summary | ||
| fi | ||
|
|
||
| # Stop GPU monitoring | ||
| stop_gpu_monitor | ||
| set +x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The new
kimik2.5-int4-b300-vllmentry inperf-changelog.yamluses a placeholderpull/XXXXinstead of the actual PR number. Please replaceXXXXwith1057before merging.Extended reasoning...
The new perf-changelog.yaml entry added by this PR (line 1414) contains a placeholder URL:
https://github.com/SemiAnalysisAI/InferenceX/pull/XXXX. This placeholder was never replaced with the actual PR number, which is known at submission time to be 1057.How it manifests: Any tooling or human reader that tries to follow the changelog link will land on a nonexistent GitHub URL, making it impossible to trace back what PR introduced the
kimik2.5-int4-b300-vllmbenchmark config.Code path: The diff shows the entry was added at the bottom of perf-changelog.yaml with
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXXX. The author appears to have copied a template and forgot to substitute the PR number.Why existing code doesn't prevent it: There is no CI validation enforcing that
pr-linkvalues contain a real PR number rather than a placeholder. The file is plain YAML with no schema enforcement on link format.Impact: Low functional impact — the benchmark config itself is correct. However, the changelog entry becomes untraceable: downstream consumers, auditors, or developers reviewing history cannot click through to understand what changed, why the B200 recipe was reused, or who approved it. Changelog hygiene matters for a public benchmarking project.
Fix: Replace
XXXXwith1057on line 1414:Step-by-step proof:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXXX.https://github.com/SemiAnalysisAI/InferenceX/pull/XXXXreturns a 404/invalid URL — the page does not exist.https://github.com/SemiAnalysisAI/InferenceX/pull/1057resolves to this very PR.pull/XXXplaceholders (lines 12, 19, 315, 790, 818, 855, 872), but those are pre-existing issues unrelated to this PR. This PR introduces one new instance of this pattern that is immediately fixable.