Updated component to version 2.3.1

Semantic-Org · Mar 19, 2018 · 3b2dcc9 · 3b2dcc9
1 parent d6390dd
commit 3b2dcc9
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,3 +1,7 @@
+### Version 2.3.1 - Mar 19, 2018
+
+- **Visibility** - Fixed bug that could cause `onScreen` callback to not occur properly for elements that are taller than screen.
+
 ### Version 2.2.14 - Jan 29, 2018
 
 - **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions

diff --git a/composer.json b/composer.json
@@ -15,5 +15,5 @@
     "framework"
   ],
   "license": "MIT",
-  "version": "2.3.0"
+  "version": "2.3.1"
 }
diff --git a/index.js b/index.js
@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.3.0 - Visibility
+ * # Semantic UI 2.3.1 - Visibility
  * https://github.com/semantic-org/semantic-ui/
  *
  *
@@ -10,7 +10,7 @@
 
 ;(function ($, window, document, undefined) {
 
-"use strict";
+'use strict';
 
 window = (typeof window != 'undefined' && window.Math == Math)
   ? window
@@ -934,7 +934,7 @@ module.exports = function(parameters) {
             element.percentagePassed = 0;
 
             // meta calculations
-            element.onScreen  = (element.topVisible && !element.bottomPassed);
+            element.onScreen  = ((element.topVisible || element.passing) && !element.bottomPassed);
             element.passing   = (element.topPassed && !element.bottomPassed);
             element.offScreen = (!element.onScreen);
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "semantic-ui-visibility",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "title": "Semantic UI - Visibility",
   "description": "Single component release of visibility",
   "homepage": "http://www.semantic-ui.com",

diff --git a/visibility.js b/visibility.js
@@ -1,5 +1,5 @@
 /*!
- * # Semantic UI 2.3.0 - Visibility
+ * # Semantic UI 2.3.1 - Visibility
  * https://github.com/semantic-org/semantic-ui/
  *
  *
@@ -10,7 +10,7 @@
 
 ;(function ($, window, document, undefined) {
 
-"use strict";
+'use strict';
 
 window = (typeof window != 'undefined' && window.Math == Math)
   ? window
@@ -933,7 +933,7 @@ $.fn.visibility = function(parameters) {
             element.percentagePassed = 0;
 
             // meta calculations
-            element.onScreen  = (element.topVisible && !element.bottomPassed);
+            element.onScreen  = ((element.topVisible || element.passing) && !element.bottomPassed);
             element.passing   = (element.topPassed && !element.bottomPassed);
             element.offScreen = (!element.onScreen);
 

diff --git a/visibility.min.js b/visibility.min.js