Add missing comma: makes 9 global vars local #6136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this needs merging |
|
This should only affect the script used to build the project as an admin to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a simple typo with significant consequences.
The missing colon at the end of line 68 causes implicit semicolon
insertion to happen, this ends the variable declaration statement that
starts on line 67. The nine assignments on the 69-79 then becomes
assignments to global variables.
I found this error with automatic analysis of your project:
https://lgtm.com/projects/g/Semantic-Org/Semantic-UI/snapshot/afe18811db795be24bdb23ca99b22ac2fa948aad/files/tasks/admin/components/init.js?sort=name&dir=ASC&mode=heatmap&excluded=false
You can see more (less serious) errors here: https://lgtm.com/projects/g/Semantic-Org/Semantic-UI/alerts
(full disclosure: I work for lgtm.com)