Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix horizontal scrollbar height, closes #5728 #5749

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Fix horizontal scrollbar height, closes #5728 #5749

merged 1 commit into from
Jan 29, 2018

Conversation

jayphelps
Copy link
Contributor

See #5728 for issue details.

The contributing docs say:

All pull requests should be merged into the next branch.

But if I set that as the PR target it appears next is 13 commits behind master, so it wants to include those commits too. Is that instruction out of date maybe?

@jayphelps jayphelps mentioned this pull request Nov 28, 2017
Closed
@jlukic jlukic changed the base branch from master to next December 22, 2017 06:05
@jlukic
Copy link
Member

jlukic commented Dec 22, 2017 •
edited
Loading

Probably should target this with :horizontal pseudo class for clarity, although i dont believe fixed height would affect vertical scrollbars, it might be funny for the rule to apply.

@jlukic jlukic added this to the 2.2.14 milestone Dec 22, 2017
@jlukic jlukic merged commit 6b3dbcd into Semantic-Org:next Jan 29, 2018
@jlukic
Copy link
Member

jlukic commented Jan 29, 2018

@jayphelps this is in the release going out now, 2.2.14

Thanks for your patience. New updates will be quicker in the new year.

@brownspy1 brownspy1 mentioned this pull request Jun 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2.14
Development

Successfully merging this pull request may close these issues.
2 participants
@jayphelps @jlukic