Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Display sub menu on the left when if cannot fit screen #4211

Merged
merged 13 commits into from
Jul 11, 2017
Merged

[Dropdown] Display sub menu on the left when if cannot fit screen #4211

merged 13 commits into from
Jul 11, 2017

Conversation

Graveheart
Copy link
Contributor

@Graveheart Graveheart commented Jul 4, 2016 •
edited
Loading

Fixes issue #4112

This change is Reviewable

@jlukic jlukic added this to the 2.2.4 milestone Jul 28, 2016
@jlukic
Copy link
Member

jlukic commented Jul 28, 2016

Looks good, I'll try to review sometime soon.

@Graveheart
Copy link
Contributor Author

Cool, that would be great

Comments from Reviewable

@tikoflano tikoflano mentioned this pull request Aug 1, 2016
Closed
@jlukic jlukic modified the milestones: 2.2.6, 2.2.7 Oct 28, 2016
@s-devaney
Copy link

LGTM

@andreiho
Copy link
Contributor

@jlukic Any updates on this? Can we expect it included in a release anytime soon?

@jlukic jlukic modified the milestones: 2.2.8, 2.2.9 Feb 21, 2017
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic jlukic merged commit 06aaeb0 into Semantic-Org:next Jul 11, 2017
jlukic added a commit that referenced this pull request Jul 11, 2017
@jlukic
#4211 Change is.fitWidth to can.openRightward, fix logic to work afte…
3b802c3 
…r setting leftward
jlukic added a commit that referenced this pull request Jul 11, 2017
@jlukic
Fix top right pointing dropdown to move arrow when leftward #4211
b13bef1
@jlukic
Copy link
Member

jlukic commented Jul 11, 2017 •
edited
Loading

@Graveheart In my testing it appeared after leftward was set it would reset to rightward on every other open because it would then pass the is.fitWidth (now `can.openRightward) function.

I've fixed this, and also modified the css to move the pointer with pointing dropdown menu when opening leftward

jlukic added a commit that referenced this pull request Jul 11, 2017
@jlukic
#4211 - Fix left pointing menu to swap sides with leftward
9425380
@andreiho
Copy link
Contributor

@jlukic Thanks.

@layershifter layershifter mentioned this pull request Jul 11, 2017
Closed
@mcosta74 mcosta74 mentioned this pull request Aug 3, 2017
Open
@pzanitti pzanitti mentioned this pull request Apr 27, 2018
Closed
@prudho prudho mentioned this pull request Jul 24, 2018
Merged
@andreiho andreiho mentioned this pull request Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Evaluating Bug / Change
Projects
None yet
Milestone
2.2.11
Development

Successfully merging this pull request may close these issues.
4 participants
@Graveheart @jlukic @s-devaney @andreiho