Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Failing silently in 2.4.1 #6622

Closed
eoliphan opened this issue Oct 14, 2018 · 6 comments
Closed

[Build] Failing silently in 2.4.1 #6622

eoliphan opened this issue Oct 14, 2018 · 6 comments
Labels
Confirmed Bug High Priority

Comments

@eoliphan
Copy link

Steps

run gulp build

Expected Result

Output CSS bundle

Actual Result

No CSS, the build process stops after creation of checkbox.min.css. Reverting to 2.4.0 works with no issues

[09:35:55] Created: ../resources/public/css/components/accordion.min.css
[09:35:55] Created: ../resources/public/css/components/checkbox.css
[09:35:55] Created: ../resources/public/css/components/checkbox.min.css
Erichs-MBP:semantic ErichOliphant$

Version

2.4.1
@ColinFrick
Copy link

I can confirm this problem

@y0hami
Copy link
Member

y0hami commented Oct 15, 2018 •
edited
Loading

@jlukic You may have to revert the gulp PR since that is the reason it is failing.

You also can't run npm install --save semantic-ui since it just fails to run the install script.

himanshu230 added a commit to himanshu230/Semantic-UI that referenced this issue Oct 17, 2018
@himanshu230
Fixes the issue where gulp build was not building all css files Seman…
e681c1e 
…tic-Org#6622 Semantic-Org#6067
himanshu230 added a commit to himanshu230/Semantic-UI that referenced this issue Oct 17, 2018
@himanshu230
Fixes the issue where gulp build was not building all css files Seman…
7edc459 
…tic-Org#6622 Semantic-Org#6067
@himanshu230 himanshu230 mentioned this issue Oct 17, 2018
Closed
@ColinFrick ColinFrick mentioned this issue Oct 17, 2018
Closed
@himanshu230
Copy link

Hi All,
I have made a PR which solves the issue #6631

@y0hami y0hami mentioned this issue Oct 17, 2018
Closed
@jlukic
Copy link
Member

jlukic commented Oct 21, 2018 •
edited
Loading

I've been on vacation in Ireland from about an hour after releasing 2.4.1 until now.

Will take a look at issue and related PR

jlukic added a commit that referenced this issue Oct 21, 2018
@jlukic
Fix cloned gulp task stream is still using original stream. #6631 #6622
22a0c7b
@jlukic
Copy link
Member

jlukic commented Oct 21, 2018

Comments left for fix on #6631

@jlukic jlukic closed this as completed Oct 21, 2018
@jlukic
Copy link
Member

jlukic commented Oct 21, 2018

2.4.2 released with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jlukic @eoliphan @ColinFrick @y0hami @himanshu230