Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components should use @normal font weight variable #6227

Closed
rijk opened this issue Feb 27, 2018 · 2 comments
Closed

Components should use @normal font weight variable #6227

rijk opened this issue Feb 27, 2018 · 2 comments
Labels
Enhancement
Milestone
2.3.1

Comments

@rijk
Copy link
Member

rijk commented Feb 27, 2018 •
edited
Loading

Variable: @normal is not used in all of the components. I think it should be used everywhere instead of normal.
@jlukic jlukic added this to the 2.3.1 milestone Feb 28, 2018
@jlukic
Copy link
Member

jlukic commented Feb 28, 2018 •
edited
Loading

Yep forgot to replace in variable files. Will fix in patch

jlukic added a commit that referenced this issue Mar 18, 2018
@jlukic
Adds @Normal usage for non default themes #6227
87c62ff
@jlukic
Copy link
Member

jlukic commented Mar 18, 2018

It looks like only the non-default theme were missing variables. Added in next.

@jlukic jlukic closed this as completed Mar 18, 2018
@brownspy1 brownspy1 mentioned this issue Jun 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
3 participants
@jlukic @rijk @y0hami