Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shape] Shape new settings not working #4181

Closed
vinh123456789 opened this issue Jun 28, 2016 · 2 comments
Closed

[Shape] Shape new settings not working #4181

vinh123456789 opened this issue Jun 28, 2016 · 2 comments
Labels
Confirmed Bug High Priority

Comments

@vinh123456789
Copy link

Hi, i just tried the new shape settings, but it not working when i set width and height to "next". Browser's console display this error "$nextSide is undefined".
http://jsfiddle.net/nufdffts/1/
@jlukic
Copy link
Member

jlukic commented Jun 30, 2016

There are a few bad bugs in shape it appears. I'm not sure how this got through. I'll try to solve quickly

@jlukic jlukic closed this as completed in 2af76ba Jun 30, 2016
@jlukic
Copy link
Member

jlukic commented Jun 30, 2016 •
edited
Loading

Fixed issues with width: 'next' breaking. Variable order was incorrect..

The animations appearing incorrectly only occurs in jQuery 3.0. I'm not sure the cause. Investigating now.

jlukic added a commit that referenced this issue Jun 30, 2016
@jlukic
#4181 fix issue with jQ 3.0 width calculations causing shape to break
2b955e0
ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Jul 1, 2016
@ali1k
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI …
e801199 
…into Semantic-Org-master

* 'master' of https://github.com/Semantic-Org/Semantic-UI: (316 commits)
  Semantic-Org#4181 fix issue with jQ 3.0 width calculations causing shape to break
  Fix Semantic-Org#4181
  Semantic-Org#4192
  Build 2.2.1
  Fix selection issue with <select> and userAdditions
  Rlsnotes
  Build 2.2 for release
  Build 2.2 for release
  Build final dist
  Rlsnotes Semantic-Org#4144
  Rlsnotes noodling
  Semantic-Org#4167 - Tabular menu now has correct bottom margin in all cases
  Fix
  Fix rlsnotes
  Fix issue with hideAdditions where enter key would not select value when typing rapidly
  Update rlsnotes
  More accurate arrow positioning in tooltips
  Remove duplicate height definition
  Reset some styles in tooltip
  Fix issue where selection was borked for search inside menu
  ...
ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Jul 1, 2016
@ali1k
Merge branch 'Semantic-Org-master'
5e2d5c2 
* Semantic-Org-master: (316 commits)
  Semantic-Org#4181 fix issue with jQ 3.0 width calculations causing shape to break
  Fix Semantic-Org#4181
  Semantic-Org#4192
  Build 2.2.1
  Fix selection issue with <select> and userAdditions
  Rlsnotes
  Build 2.2 for release
  Build 2.2 for release
  Build final dist
  Rlsnotes Semantic-Org#4144
  Rlsnotes noodling
  Semantic-Org#4167 - Tabular menu now has correct bottom margin in all cases
  Fix
  Fix rlsnotes
  Fix issue with hideAdditions where enter key would not select value when typing rapidly
  Update rlsnotes
  More accurate arrow positioning in tooltips
  Remove duplicate height definition
  Reset some styles in tooltip
  Fix issue where selection was borked for search inside menu
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlukic @vinh123456789