Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] hideAdditions should be false by default #4052

Open
elamm2040 opened this issue May 20, 2016 · 13 comments
Open

[Dropdown] hideAdditions should be false by default #4052

elamm2040 opened this issue May 20, 2016 · 13 comments

Comments

@elamm2040
Copy link

elamm2040 commented May 20, 2016

i have a Dropdown with property allowAdditions but is not working, how do I fix this?

my code:

<div class="ui multiple search selection dropdown">
    <input type="hidden"> <i class="dropdown icon"></i>
    <div class="default text">Animals</div>
    <div class="menu"></div>
</div>
$('.ui.dropdown').dropdown({
    allowAdditions: true
});
@groeney
Copy link

groeney commented Jul 10, 2016

I'm having this same issue since upgrading from SUI 2.1 to 2.2.1. Sorry I don't have any solutions as yet.

To clarify my problem:
message: { addResult: 'Add {term}' } is not displaying. When there is no match in the menu, the dropdown menu simply closes with no UX indicating that the user can add a new term. The example in the docs also seems to be behaving this way -- http://semantic-ui.com/modules/dropdown.html#/examples

Important: A new label does indeed get created and added after user hits enter.

So I guess technically allowAdditions is working, though the UX is a little off.

@jlukic is there a known issue with 2.2.1 selection dropdown allowAdditions UX?

@JakeAlmer
Copy link

Broken for me also. Reproduced in the dropdown demos (http://semantic-ui.com/modules/dropdown.html#tagging-and-user-additions). Chrome 51.0.2704.106 m.

@JakeAlmer
Copy link

JakeAlmer commented Jul 19, 2016

Looks like the change was introduced in 6562429. I'm having trouble telling if it was on purpose or not. Previously you did not need to specify hideAdditions, now you do.

jsFiddle showing the difference

@swendrich
Copy link

swendrich commented Jul 27, 2016

Same here! Would be great if the old behavior is brought back. Using hideAdditions: false fixed it.

@OleksandrK
Copy link

Thank you Swendrich, you saved me a lot of time!
The value of hideAdditions should be just false by default (imho).

@richardtallent
Copy link

In case anyone else googles and finds this, the "search" class is required for allowAdditions to work. This is not clear in the documentation.

@whymahyah
Copy link

Is there way to disable case sensitivity on allowAdditions?
screenshot from 2017-02-06 18 44 19

@awgv
Copy link
Member

awgv commented Feb 9, 2017

@whymahyah not that I know of. There’s a PR #3432 that might make it into the next release, but it will take a while.

Closing the issue as resolved.

@awgv awgv closed this as completed Feb 9, 2017
@JakeAlmer
Copy link

@Banandrew why is this resolved? @whymahyah question was unrelated to the original issue reported.

As originally asked, was the change in behavoir a desired change or a mistake?

@awgv
Copy link
Member

awgv commented Feb 10, 2017

@JakeAlmer I understand that the question was unrelated; it was resolved, because I thought it was a usage question. I don’t know if the change was a mistake, and Jack has his hands full currently—frankly, I don’t think it matters at this point. Would you prefer hideAdditions to be false by default?

@nickclyde
Copy link

Makes more sense to have hideAdditions be false by default, because that's how it was before it became a new option. Having it true by default breaks previous behavior. Though I can see how it is a useful option to have!

@awgv awgv reopened this Feb 11, 2017
@awgv awgv changed the title dropdown with allowAdditions [Dropdown] hideAdditions should be false by default Feb 11, 2017
@awgv awgv added this to the Needs Milestone milestone Feb 12, 2017
@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@stale stale bot closed this as completed Mar 25, 2018
@awgv awgv reopened this Mar 25, 2018
@stale stale bot removed the stale label Mar 25, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants