Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Small Size Variations in REM #3782

Closed
zuck opened this issue Mar 4, 2016 · 1 comment
Closed

[Icon] Small Size Variations in REM #3782

zuck opened this issue Mar 4, 2016 · 1 comment
Labels
Confirmed Bug
Milestone
2.2

Comments

@zuck
Copy link

zuck commented Mar 4, 2016

I found icon size variations are incoherent: it seems that mini and tiny use rem as scaling factor, while the others use em.

I don't know which one is desired by design.

This is the test case:

http://jsfiddle.net/r5w62dxL/1/
@jlukic
Copy link
Member

jlukic commented Mar 4, 2016

This is just incorrect. Thanks

@jlukic jlukic added this to the 2.1.9 milestone Mar 4, 2016
@jlukic jlukic changed the title Icon size variations: some use "rem", some "em" [Icon] Small Size Variations in REM Mar 4, 2016
jlukic added a commit that referenced this issue Mar 7, 2016
@jlukic
Fix rem sizing on icon #3782
6552df0
@jlukic jlukic closed this as completed Mar 7, 2016
@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@jlukic @zuck