Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown module doesn't implement addResult message #2923

Closed
Neaox opened this issue Aug 28, 2015 · 1 comment
Closed

Dropdown module doesn't implement addResult message #2923

Neaox opened this issue Aug 28, 2015 · 1 comment
Labels
Confirmed Bug
Milestone
2.1

Comments

@Neaox
Copy link
Contributor

Neaox commented Aug 28, 2015

I assume that message.addResult is used to format the add item message when allowAdditions is true.

This property is never utilised within the Dropdown module.

See: https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/modules/dropdown.js#L3198
@jlukic jlukic added this to the 2.1 milestone Sep 1, 2015
jlukic added a commit that referenced this issue Sep 1, 2015
@jlukic
Fixes #2923 issue with allow additions not implementing add results t…
e65bfa2 
…emplate
@jlukic
Copy link
Member

jlukic commented Sep 1, 2015

Implemented this, and the UX is much better. Now you can tell difference between user addition and normal selection.

@jlukic jlukic closed this as completed Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@jlukic @Neaox