Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached labels leave a small gap #2500

Closed
celsworth opened this issue Jul 2, 2015 · 2 comments
Closed

Attached labels leave a small gap #2500

celsworth opened this issue Jul 2, 2015 · 2 comments
Milestone

Comments

@celsworth
Copy link

This is really quite a minor defect, but attached labels don't quite have the same border-radius as the segment they're in; this is from the Semantic docs:

Easier to see with a brighter colour; an orange corner attached label inside an orange segment.

Be nice if that little flash of white gap wasn't there so it looked all nicely integrated :)

@jlukic jlukic added this to the 2.0.x milestone Jul 2, 2015
@jlukic
Copy link
Member

jlukic commented Jul 4, 2015

Although the labels match the border radius of outside segment. I think this is a math thing with radius of the "inside" of the border vs "outside" (since these are offset from edge of border).

Pretty sure I can solve this by reducing border radius by a pixel.

@jlukic
Copy link
Member

jlukic commented Jul 6, 2015

I've reduced the border radius of inner label corners which should make this appear closer to correct. This is still an approximation since the border radius does not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants