Skip to content

Commit

Permalink
#2644 remove unnecessary call to remove direction in destroy
Browse files Browse the repository at this point in the history
  • Loading branch information
jlukic committed Jul 17, 2015
1 parent 1e6e843 commit d74255f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- **Form** - Added `doesntContain` and `doesntContainExactly` #
- **Form** - Fixes errors when a field identifier is named `identifier` #2629
- **Formatting** - Fixed several source files that had `CR LF` (Windows) line endings #2649
- **Sidebar** - `right`, `top`, and `bottom` sidebar will not have their direction removed on `destroy` #2644

**Additional Bugs**
- **Popup** - `wide` and `very wide` popup will now limit themselves to normal popup widths on mobile so that they still appear on screen.
Expand Down
1 change: 0 additions & 1 deletion src/definitions/modules/sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ $.fn.sidebar = function(parameters) {

destroy: function() {
module.verbose('Destroying previous module for', $module);
module.remove.direction();
$module
.off(eventNamespace)
.removeData(moduleNamespace)
Expand Down

0 comments on commit d74255f

Please sign in to comment.