#2973 - fixes spacing on right icon inside labeled icon button

Semantic-Org · Sep 13, 2015 · ad4a057 · ad4a057
1 parent 92e0ee2
commit ad4a057
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -6,8 +6,11 @@
 - **Build** - Fixed issue where using a packaged theme without a `site.variables` would cause build to fail
 
 **Bugfixes**
+- **Button** -
 - **Table** - Fixed issue where `(x) column segment table` was inheriting accidentally inheriting some grid styles
-
+- **Grid** - Fixed `middle aligned grid` not applying to columns #2959
+- **Menu** - Fixed issue where `right menu` was not floating correctly inside a `menu > container` on mobile #2969
+- **Button** - Fixes `right labeled icon button` with a `right` named icon (for example `right arrow`) having incorrect margin on icon. #2973
 
 ### Version 2.1.3 - Sep 03, 2015
 

diff --git a/src/definitions/elements/button.less b/src/definitions/elements/button.less
@@ -834,10 +834,11 @@
   border-radius: 0px;
   border-top-left-radius: inherit;
   border-bottom-left-radius: inherit;
+  text-align: center;
 
+  margin: @labeledIconMargin;
   width: @labeledIconWidth;
   background-color: @labeledIconBackgroundColor;
-  text-align: center;
   color: @labeledIconColor;
   box-shadow: @labeledIconLeftShadow;
 }

diff --git a/src/themes/default/elements/button.variables b/src/themes/default/elements/button.variables
@@ -167,6 +167,7 @@
 @labeledLabelBorderColor: @borderColor;
 @labeledLabelBorderOffset: -@borderBoxShadowWidth;
 @labeledTagLabelSize: 1.85em; /* hypotenuse of triangle */
+@labeledIconMargin: 0em;
 
 /* Labeled Icon */
 @labeledIconWidth: 1em + (@verticalPadding * 2);