Skip to content

Commit

Permalink
Fixed inconsistent use of media query breakpoints
Browse files Browse the repository at this point in the history
 - @largest* should only be used by max-width queries
 - @*Breakpoint should only be used by min-width queries
  • Loading branch information
mdehoog committed Oct 14, 2015
1 parent 76678c1 commit 0952017
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/definitions/elements/divider.less
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
}

/* Inside grid */
@media only screen and (max-width : (@tabletBreakpoint - 1px)) {
@media only screen and (max-width : @largestMobileScreen) {

.ui.stackable.grid .ui.vertical.divider,
.ui.grid .stackable.row .ui.vertical.divider {
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/elements/step.less
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@
---------------*/

/* Tablet Or Below */
@media only screen and (max-width: @computerBreakpoint) {
@media only screen and (max-width: @largestTabletScreen) {

.ui[class*="tablet stackable"].steps {
display: inline-flex;
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/modal.less
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
}

/* Tablet and Mobile */
@media only screen and (max-width : @computerBreakpoint) {
@media only screen and (max-width : @largestTabletScreen) {
.ui.modal > .header {
padding-right: @closeHitbox;
}
Expand Down Expand Up @@ -313,7 +313,7 @@
}

/* Tablet and Mobile */
@media only screen and (max-width : @computerBreakpoint) {
@media only screen and (max-width : @largestTabletScreen) {
.ui.basic.modal > .close {
color: @basicInnerCloseColor;
}
Expand Down Expand Up @@ -371,7 +371,7 @@
z-index: auto;
}

@media only screen and (max-width : @computerBreakpoint) {
@media only screen and (max-width : @largestTabletScreen) {
.modals.dimmer .ui.scrolling.modal {
margin-top: @mobileScrollingMargin !important;
margin-bottom: @mobileScrollingMargin !important;
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/views/ad.less
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
display: none;
}

@media only screen and (max-width : (@tabletBreakpoint - 1)) {
@media only screen and (max-width : @largestMobileScreen) {
.ui.mobile.ad {
display: block;
}
Expand Down

0 comments on commit 0952017

Please sign in to comment.