BREAKING CHANGE: Loader component refactor #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)
|
33 tasks
layershifter
commented
Oct 10, 2016
| }) | ||
| }) | ||
|
|
||
| describe('text (class)', () => { |
Member
Author
There was a problem hiding this comment.
This can be replaced with commonTest, by I don't sure that it's good idea.
common.propKeyOnlyToClassName(Loader, 'text', {
requiredProps: { children: faker },
})
common.propKeyOnlyToClassName(Loader, 'text', {
requiredProps: { content: faker },
})
Member
There was a problem hiding this comment.
I agree - it would technically test the same thing but I don't think it would be as clear what you're actually testing.
jeffcarbs
approved these changes
Oct 11, 2016
Member
jeffcarbs
left a comment
jeffcarbs
left a comment
There was a problem hiding this comment.
LGTM and codecov is showing no drop in coverage (https://codecov.io/gh/Semantic-Org/Semantic-UI-React/commit/ba955b37fb58484b0b06ea9315f7e9bf2690639a) 👍
levithomason
changed the title
Member
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Loaderwarning in tests (docs(Example): Fix warnings #599);contentshorthand instead oftext.Is breaking change.