fix(doesNodeContainClick): only use x/y if !e.target #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 154 154
Lines 2711 2711
=======================================
Hits 2704 2704
Misses 7 7Continue to review full report at Codecov.
|
levithomason
force-pushed
the
fix/does-node-contain-click
branch
2 times, most recently
from
27fdc4e to
89217ef
Compare
levithomason
force-pushed
the
fix/does-node-contain-click
branch
from
89217ef to
a33fda2
Compare
|
Released in |
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493
If the
documentcontains thee.target, then rely on thenode.contains(e.target)method for checking if a click was within anode.Only in cases where the
e.targetis no longer in thedocumentdo we need to resort to measuring the click position.