Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Progress): Add value option, to just show the value in the bar #2383

Merged
merged 6 commits into from
Jan 10, 2018
Merged

feat(Progress): Add value option, to just show the value in the bar #2383

merged 6 commits into from
Jan 10, 2018

Conversation

UnbrandedTech
Copy link
Contributor

@UnbrandedTech UnbrandedTech commented Dec 14, 2017

This PR adds ability to pass value to Progress:

  <Progress progress='value' value={35} />

@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #2383 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
+ Coverage   99.73%   99.73%   +<.01%     
==========================================
  Files         152      152              
  Lines        2664     2669       +5     
==========================================
+ Hits         2657     2662       +5     
  Misses          7        7
Impacted Files Coverage Δ
src/modules/Progress/Progress.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2f3fc...b2b680d. Read the comment docs.

@UnbrandedTech
Copy link
Contributor Author

Hey @layershifter or @levithomason, I think this is good to go. Let me know what you think.
This is what im trying to accomplish btw. I'll deal with the css, but the value inside is what I need.
screen shot 2017-12-14 at 9 32 47 am

@UnbrandedTech UnbrandedTech changed the title Add value option, to just show the value of the bar feat(Progress): Add value option, to just show the value in the bar Dec 14, 2017
@levithomason
Copy link
Member

levithomason commented Dec 14, 2017

Though this is an extension of the SUI Progress settings, I think it makes sense. If you could add some tests , typings, and docs to this we can merge it.

@UnbrandedTech
Copy link
Contributor Author

I'm not sure why that test it failing....

@layershifter
Copy link
Member

@levithomason I'm pushed some changes to make this working, however I think that it will be better if we will introduce Progress.Progress component and allow to use it as shorthand.

@UnbrandedTech
Copy link
Contributor Author

Any update on this?

@levithomason
Copy link
Member

This looks good to me.

@layershifter what do you mean about Progress.Progress, can you give some shorthand examples? Maybe we do this in another PR?

@levithomason levithomason merged commit 380cf90 into Semantic-Org:master Jan 10, 2018
@levithomason
Copy link
Member

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants