-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Progress): Add value option, to just show the value in the bar #2383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2383 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 152 152
Lines 2664 2669 +5
==========================================
+ Hits 2657 2662 +5
Misses 7 7
Continue to review full report at Codecov.
|
Hey @layershifter or @levithomason, I think this is good to go. Let me know what you think. |
Though this is an extension of the SUI Progress settings, I think it makes sense. If you could add some tests |
I'm not sure why that test it failing.... |
@levithomason I'm pushed some changes to make this working, however I think that it will be better if we will introduce |
Any update on this? |
This looks good to me. @layershifter what do you mean about |
Released in |
This PR adds ability to pass
value
toProgress
: