-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Visibility): add fireOnMount #2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
+ Coverage 99.76% 99.76% +<.01%
==========================================
Files 148 148
Lines 2556 2557 +1
==========================================
+ Hits 2550 2551 +1
Misses 6 6
Continue to review full report at Codecov.
|
d74de1b
to
8a15d75
Compare
Made a small verbiage tweak, will merge on pass. |
Released in |
* feat(Visibility): add fireOnMount * docs(Visibility): remove "once" from fireOnMount
Hello Guys! I'm basically trying to show a react element that is onScreen on first render. So, I found Visibility: onOnScreen doesn't fire if element is onScreen on first render, which lead me to this page here. 1)According to the comment on this page on Sep 11, a fix was released at version 0.73.0 2)Also, if I include the fireOnMount prop on the Visibility tag, then calculations.onScreen is always equal to true. Is that normal? I can't understand the reason for this...What is fireOnMount for? I don't get it from the docs https://semantic-ui.com/behaviors/visibility or https://react.semantic-ui.com/behaviors/visibility Here is a codesandbox: https://codesandbox.io/s/nr5k9k6zwp Thanks for any assistance on these 2 points |
If you want to get help, you should create a new issue and fully fill issue template. |
Fixes #1911.