feat(Transition): make duration prop more advanced
#1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Aug 15, 2017
| @@ -5,7 +5,7 @@ const transitions = ['jiggle', 'flash', 'shake', 'pulse', 'tada', 'bounce'] | |||
|
|
|||
| const options = transitions.map(name => ({ key: name, text: name, value: name })) | |||
|
|
|||
| export default class TransitionExampleStaticExplorer extends Component { | |||
| export default class TransitionExampleTransitionExplorer extends Component { | |||
There was a problem hiding this comment.
Name example's class as file
layershifter
commented
Aug 15, 2017
| @@ -1,11 +1,10 @@ | |||
| import React from 'react' | |||
| import { Message } from 'semantic-ui-react' | |||
layershifter
commented
Aug 15, 2017
| import { Message } from 'semantic-ui-react' | ||
|
|
||
| const TransitionTypesExamples = () => ( | ||
| const TransitionExplorersExamples = () => ( |
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2580 2584 +4
=========================================
+ Hits 2575 2579 +4
Misses 5 5
Continue to review full report at Codecov.
|
| @@ -25,7 +31,13 @@ export default class Transition extends Component { | |||
| children: PropTypes.element.isRequired, | |||
|
|
|||
| /** Duration of the CSS transition animation in milliseconds. */ | |||
| duration: PropTypes.number, | |||
| duration: PropTypes.oneOfType([ | |||
| PropTypes.number, | |||
There was a problem hiding this comment.
Looks like we technically also support a string here.
| @@ -15,7 +15,7 @@ export interface TransitionProps { | |||
| children?: React.ReactNode; | |||
|
|
|||
| /** Duration of the CSS transition animation in milliseconds. */ | |||
| duration?: number; | |||
| duration?: number | TransitionPropDuration; | |||
There was a problem hiding this comment.
String is also supported, correct?
| @@ -14,7 +16,7 @@ export interface TransitionGroupProps { | |||
| children?: React.ReactNode; | |||
|
|
|||
| /** Duration of the CSS transition animation in milliseconds. */ | |||
| duration?: number; | |||
| duration?: number | TransitionPropDuration; | |||
| @@ -31,7 +31,13 @@ export default class TransitionGroup extends React.Component { | |||
| children: PropTypes.node, | |||
|
|
|||
| /** Duration of the CSS transition animation in milliseconds. */ | |||
| duration: PropTypes.number, | |||
| duration: PropTypes.oneOfType([ | |||
| PropTypes.number, | |||
There was a problem hiding this comment.
Finally, let's add string as a supported type here too.
levithomason
force-pushed
the
feat/transition-duration
branch
from
5f9cbc0 to
f511e0e
Compare
|
I've rebased to the latest master and added string duration propType / typings support. Will merge on pass. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes possible to define diffent durations for
hideandshowactions.