chore(package): switch to react-hot-loader #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
==========================================
- Coverage 99.77% 99.77% -0.01%
==========================================
Files 148 148
Lines 2640 2637 -3
==========================================
- Hits 2634 2631 -3
Misses 6 6
Continue to review full report at Codecov.
|
webpack.config.js
Outdated
| cacheDirectory: true, | ||
| }, | ||
| }, | ||
| loaders: jsLoaders, |
There was a problem hiding this comment.
I think this should be a use: [] and not loaders: [], correct?
There was a problem hiding this comment.
@levithomason Thanks for your eyes, docs sent me the wrong way
layershifter
force-pushed
the
chore/react-hot-loader
branch
from
fe2ad69 to
ea3af63
Compare
| cacheDirectory: true, | ||
| }, | ||
| }] | ||
| if (__DEV__) jsLoaders.unshift('react-hot-loader/webpack') |
There was a problem hiding this comment.
Does this work as is? I'm not as solid with webpack 2 yet, but the docs show only this syntax:
-if (__DEV__) jsLoaders.unshift('react-hot-loader/webpack')
+if (__DEV__) jsLoaders.unshift({ loader: 'react-hot-loader/webpack' })There was a problem hiding this comment.
I can find this in docs, but it works.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #1895.
Details