chore(package): update chai to version 4.0.2 #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some of our deps' peers are not https://circleci.com/gh/Semantic-Org/Semantic-UI-React/2972
|
layershifter
changed the title
|
Tracking: |
added 2 commits
June 13, 2017 12:19
…b.com/Semantic-Org/Semantic-UI-React into greenkeeper-chai-4.0.1 # Conflicts: # package.json
|
Only
|
added 2 commits
June 30, 2017 15:28
| @@ -37,6 +37,7 @@ module.exports = (karmaConfig) => { | |||
| includeAllSources: true, | |||
| }, | |||
| files: [ | |||
| 'node_modules/es6-shim/es6-shim.js', | |||
There was a problem hiding this comment.
I added es-shim because PhantomJS doesn't want run tests, SO.
Codecov Report
@@ Coverage Diff @@
## master #1725 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 144 144
Lines 2463 2463
=======================================
Hits 2457 2457
Misses 6 6Continue to review full report at Codecov.
|
layershifter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
chai just published its new version 4.0.1.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of chai.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 352 commits .
b38b8d7fix: (#978) remove browser field (#982)d0ace69Update supported node version badge in README FIX #975ab1fbadMerge pull request #973 from chaijs/chore-uncomment-travis-deploy545ca2fchore: uncomment travis lines6349ff4Merge pull request #972 from lucasfcosta/release-4.0.00fe98b1[email protected]30a4451Merge pull request #967 from lucasfcosta/remove-lib-bump8ba95a7Remove bump command to change lib/chai.js0825826Merge pull request #964 from zetamorph/assert-nestedInclude-ownIncludef3adfd9fix: PhantomJS 1.x incompatibility (#966)b744130Assert: made documentation more descriptive33e4403test: added custom message test to negated .nested-, .deep-, .own.include4180242test: added message argument to negated nested-, deep-, own- and deepOwnInclude40bb490assert interface: add .deepOwnInclude and notdeepOwnInclude97b6243assert interface: add .ownInclude and .notOwnIncludeThere are 250 commits in total. See the full diff.