feat(TextArea): add minHeight property, docs example

[josie11]

Adds minHeight property to TextArea that can be used with autoHeight property to specify a minimum number of rows a TextArea should have. Referenced here: #1647.

I've implemented this by setting this.ref.rows = minHeight, but I'm not sure if this is the ideal way. I'd have to adjust assertHeight in the tests in order to add a test for it.

[codecov-io]

Codecov Report

Merging #1679 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files         142      142              
  Lines        2468     2466       -2     
==========================================
- Hits         2462     2460       -2     
  Misses          6        6

Impacted Files	Coverage Δ
src/addons/TextArea/TextArea.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41235c...a26a740. Read the comment docs.

[layershifter]

Thanks for PR. I think that rows should be also customizable:

static defaultProps = {
   as: 'textarea',
+  minHeight: 0,
+  rows: 5,
}

-this.ref.rows = minHeight
-this.ref.style.minHeight = '0'
+this.ref.style.minHeight = minHeight + 'px'

render() {
-  const { value } = this.props
+  const { rows, value } = this.props
// ...
- return <ElementType{...rest} onChange={this.handleChange} ref={this.handleRef} value={value} />
+  return (
+    <ElementType
+      {...rest} 
+      onChange={this.handleChange}
+      ref={this.handleRef}
+      rows={rows}
+      value={value}
+    />
+  )
}

[josie11]

I added the rows prop but I left it in updateHeight & usable with autoHeight for now - otherwise it will break tests. Also, when using autoHeight it seems the intended default rows should be 1, so there is a conflict there.

[layershifter]

I've pushed some changes there, LGTM.

However, there is one breaking change with autoHeight. Before these changes rows prop had 1 value, now it's has 3 by default.

[levithomason]

Reviewing the code changes, it strikes me odd that we're pulling autoHeight up to a prop. Perhaps it makes more sense to leave this in the style prop:

<TextArea style={{ minHeight: 100 }} />

[layershifter]

@levithomason Thanks for the feedback, I'll make these changes.

[layershifter]

I've performed there some changes. minHeight was back to style 👍

[levithomason]

Thanks much @josie11 and @layershifter!

[levithomason]

Released in [email protected]