-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Progress): use floor for data-percent attribute #1672
Conversation
Floor the data-percent attribute so Semantic UI CSS works as expected. Fixes Semantic-Org#1671
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2408 2408
=======================================
Hits 2402 2402
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickgaskill Thanks for PR. It will be awesome to get a test there that asserts that Math.floor
was done.
Superb! Thanks, folks! |
Released in |
Floor the data-percent attribute so Semantic UI CSS works as expected.
Fixes #1671