fix(Search): pressing up/down arrow in the search input causes error

[josie11]

Attempts to fix the issue raised in #1592 by adjusting how event listeners are added/removed based on search results.

[codecov-io]

Codecov Report

Merging #1600 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2396     2397       +1     
==========================================
+ Hits         2390     2391       +1     
  Misses          6        6

Impacted Files	Coverage Δ
src/modules/Search/Search.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ff255...bb8b83f. Read the comment docs.

[GregoryPotdevin]

Wouldn't it be safer to let the event listeners as usual (after all, the "no result" is still an open popup) but fix the listener functions to not throw an error if the results are empty? Is there a risk of keyboard events bubbling up if they aren't caught when there are no results?

[levithomason]

The Dropdown is almost a copy of this component. Ideally, it would share base logic and features, however, that work was begun but not completed.

It may also be worth looking at how the Dropdown solved this issue. It has the same methods but over time has had a lot more attention and therefore fixes.

[josie11]

Oops, I should have examined scrollSelectedItemIntoView closer instead of making all those other changes, sorry!
I adjusted this to match to how I perceive Dropdown handles this, which is seemingly a one line fix?

[levithomason]

On the surface, this sounds right. There may is likely also a test we can copy over as well that ensures pressing arrow keys when there are no results actually works.

[levithomason]

Going to merge this for now since it is such a minor fix resolves a known bug.

[levithomason]

Released in [email protected].