-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(typings): export all props interfaces #1467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2363 2363
=======================================
Hits 2357 2357
Misses 6 6 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2368 2368
=======================================
Hits 2362 2362
Misses 6 6 Continue to review full report at Codecov.
|
d2e3772
to
fda83ff
Compare
Almost done there, I want to check it with my typescript pet-project in evening. |
@mihai-dinculescu @rokoroku @DanHarman I will be glad to hear your feebback there. |
Looks good 👍 |
I am now able to do
but I'm not able to do
Same goes for the other components. Thou I'm not sure that I have taken the right approach in testing. I have built the branch and copied |
@mihai-dinculescu I've added commit that updates exports again. Can you check? I've tested with compiler in my project, project was built successfully without errors. |
Changes look good, will merge once the fixes are confirmed. |
@layershifter the TypeScript part works well but there's a React warning now.
It seems to come out of ButtonOr.js:36
|
This was fixed in #1477. |
@layershifter Then all is good! |
@levithomason Seems we can merge this 👍 |
Thanks for this @layershifter, it is currently blocking me. |
Very appreciative to everyone who tested and reported back here! |
Released in |
Fixes #1456.